feat(mcp): durcir le consentement OAuth (remember-cookie SameSite + CSRF) (#114)

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Colin Maudry
2026-07-13 15:07:59 +02:00
parent bb2aee85a2
commit d2fa17761d
6 changed files with 61 additions and 4 deletions
+21
View File
@@ -27,3 +27,24 @@ def test_render_consent_shows_redirect_host():
def test_render_subscription_required_links_abonnement():
html = consent.render_subscription_required()
assert "/compte/abonnement" in html
def test_render_consent_escapes_client_name():
html = consent.render_consent(
"<script>alert(1)</script>",
"https://claude.ai/api/mcp/auth_callback",
"mcp",
)
assert "<script>alert(1)</script>" not in html
assert "&lt;script&gt;" in html
def test_render_consent_includes_csrf_token():
html = consent.render_consent(
"Claude",
"https://claude.ai/api/mcp/auth_callback",
"mcp",
csrf_token="tok-abc-123",
)
assert 'name="csrf_token"' in html
assert "tok-abc-123" in html
+24
View File
@@ -92,6 +92,30 @@ def test_authorize_requires_subscription(flow_app, monkeypatch):
assert b"Abonnement requis" in resp.data
def test_authorize_post_requires_subscription(flow_app, monkeypatch):
from src.auth import db as auth_db
app, _ = flow_app
monkeypatch.setattr("src.mcp.oauth.consent.TOUS_ABONNES", False)
uid = auth_db.create_user("nosub2@ex.fr", "h")
client = app.test_client()
client.get(f"/_test_login/{uid}")
cid = _register(client)
_, challenge = _pkce()
qs = {
"client_id": cid,
"response_type": "code",
"redirect_uri": "https://claude.ai/api/mcp/auth_callback",
"scope": "mcp",
"code_challenge": challenge,
"code_challenge_method": "S256",
"resource": "https://colibre.fr/_mcp",
}
resp = client.post("/oauth/authorize", query_string=qs, data={"confirm": "yes"})
assert resp.status_code == 403
assert b"Abonnement requis" in resp.data
def test_full_flow_issues_audience_bound_token(flow_app, monkeypatch):
from src.auth import db as auth_db
from src.mcp.oauth import store