fix(backup): nettoyer le fichier temporaire en cas d'erreur dans restore (#89)

Wraps temp file operations in try/except to ensure the temporary database file is always cleaned up, even if an exception occurs during write_snapshot or verify_integrity.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Colin Maudry
2026-06-24 17:21:28 +02:00
parent cae0a528f3
commit ded5e66ccc
22 changed files with 6767 additions and 10 deletions
+13 -10
View File
@@ -45,15 +45,18 @@ def restore(config: BackupConfig, storage: Storage, key: str, now: datetime) ->
with tempfile.NamedTemporaryFile(suffix=".sqlite", delete=False) as tmp:
tmp_path = Path(tmp.name)
snapshot.write_snapshot(data, tmp_path)
if not snapshot.verify_integrity(tmp_path):
tmp_path.unlink(missing_ok=True)
raise ValueError(f"Sauvegarde corrompue, restauration annulée : {key}")
try:
snapshot.write_snapshot(data, tmp_path)
if not snapshot.verify_integrity(tmp_path):
raise ValueError(f"Sauvegarde corrompue, restauration annulée : {key}")
db_path = config.db_path
stamp = now.strftime("%Y%m%dT%H%M%SZ")
backup_copy = db_path.with_name(f"{db_path.name}.bak-{stamp}")
if db_path.exists():
backup_copy.write_bytes(db_path.read_bytes())
os.replace(tmp_path, db_path)
db_path = config.db_path
stamp = now.strftime("%Y%m%dT%H%M%SZ")
backup_copy = db_path.with_name(f"{db_path.name}.bak-{stamp}")
if db_path.exists():
backup_copy.write_bytes(db_path.read_bytes())
os.replace(tmp_path, db_path)
except Exception:
tmp_path.unlink(missing_ok=True)
raise
return backup_copy