d8faccab46
src/db.py : le remplacement des noms d'organisation nuls utilisait .name.keep() sur une expression concat_str référençant *_id ; Polars nommait alors le résultat d'après *_id, écrasant la colonne titulaire_id/acheteur_id et laissant *_nom inchangée. Remplacé par .alias(col). Suite de tests — élimination de la pollution inter-tests (callbacks/conn globaux Dash) qui faisait échouer ~15 tests Selenium en exécution complète : - tests/conftest.py : DUCKDB_PATH et DATA_SCHEMA_CACHE pointent sur des chemins de test isolés (tests/decp.duckdb, tests/schema.cache.json, gitignorés) — on ne touche plus jamais aux fichiers versionnés decp.duckdb et schema.fixture.json (qui étaient mutés et cassaient la collecte au run suivant). Viewport Chrome élargi à 1600px. - tests/test_db.py : fixture module-scoped qui recharge src.db après le module (test_query_marches faisait importlib.reload vers une DB temporaire au schéma réduit, polluant le conn global → ColumnNotFoundError ensuite). Assertion mise à jour pour le nouveau libellé "[Inconnu de l'INSEE (...)]". Tests périmés / fragiles corrigés : - tests/auth/test_oauth_routes.py : mock LinkedIn aligné sur la route (userinfo récupéré via .get() séparé) ; destination post-login /compte/abonnement. - tests/test_main.py : test_002 filtre sur dateNotification (uid retiré du tableau), scrollIntoView (colonne hors viewport), attentes de l'application du filtre et de la restauration de la persistance ; test_015 via wait_for_no_elements. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
375 lines
13 KiB
Python
375 lines
13 KiB
Python
import polars as pl
|
|
from dash.testing.composite import DashComposite
|
|
from selenium.webdriver import Keys
|
|
from selenium.webdriver.common.by import By
|
|
from selenium.webdriver.remote.webelement import WebElement
|
|
from selenium.webdriver.support.ui import WebDriverWait
|
|
|
|
|
|
def _wait_input_value(dash_duo, element: WebElement, expected: str, timeout=8) -> None:
|
|
"""Attend qu'un input atteigne la valeur attendue. La restauration de la
|
|
persistance des filtres est asynchrone après rechargement de page : sous
|
|
charge, lire la valeur immédiatement renvoie une chaîne vide."""
|
|
WebDriverWait(dash_duo.driver, timeout).until(
|
|
lambda _d: element.get_attribute("value") == expected
|
|
)
|
|
|
|
|
|
def _filter_input_in_view(dash_duo, selector, timeout=6) -> WebElement:
|
|
"""Attend la présence d'un input de filtre du marches_table et le ramène
|
|
dans le viewport. Le tableau a un défilement horizontal : sous charge
|
|
(suite complète), la colonne ciblée peut être hors écran, ce qui fait échouer
|
|
send_keys avec ElementNotInteractableException alors que l'élément est
|
|
pourtant rendu et visible."""
|
|
dash_duo.wait_for_element(selector, timeout=timeout)
|
|
el: WebElement = dash_duo.find_element(selector)
|
|
dash_duo.driver.execute_script(
|
|
"arguments[0].scrollIntoView({block: 'center', inline: 'center'});", el
|
|
)
|
|
return el
|
|
|
|
|
|
def test_001_logo_and_search(dash_duo: DashComposite):
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
assert dash_duo.find_element(".logo > h1").text == "decp.info"
|
|
|
|
for org_type in ["acheteur", "titulaire"]:
|
|
name = f"{org_type.upper()} 1"
|
|
search_bar: WebElement = dash_duo.find_element("#search")
|
|
|
|
dash_duo.clear_input(search_bar)
|
|
|
|
search_bar.send_keys(name)
|
|
search_bar.send_keys(Keys.ENTER)
|
|
|
|
dash_duo.wait_for_element(f"#results_{org_type}_datatable", timeout=2)
|
|
result_table: WebElement = dash_duo.find_element(
|
|
f"#results_{org_type}_datatable tbody"
|
|
)
|
|
|
|
assert len(result_table.find_elements(by=By.TAG_NAME, value="tr")) == 2, (
|
|
"The search should return only one result"
|
|
) # header row + 1 result
|
|
assert result_table.find_element(
|
|
by=By.CSS_SELECTOR, value=f'td[data-dash-column="{org_type}_nom"]'
|
|
).text.startswith(name), (
|
|
f"The search result should have the right {org_type} name"
|
|
)
|
|
|
|
|
|
def test_002_filter_persistence(dash_duo: DashComposite):
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
def open_page_and_check_filter_input():
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/{page}")
|
|
filter_input_selector = (
|
|
'.marches_table th[data-dash-column="dateNotification"] input[type="text"]'
|
|
)
|
|
return _filter_input_in_view(dash_duo, filter_input_selector)
|
|
|
|
for page in ["tableau", "acheteurs/123", "titulaires/345"]:
|
|
filter_input = open_page_and_check_filter_input()
|
|
filter_input.send_keys("11") # valeur quelconque, on teste la persistance
|
|
filter_input.send_keys(Keys.ENTER)
|
|
# Attendre que le filtre soit réellement appliqué (la table se vide :
|
|
# "11" ne matche aucune dateNotification) AVANT de re-naviguer. Sinon, on
|
|
# peut quitter la page avant que le callback de filtre ait écrit la
|
|
# persistance → la valeur n'est pas restaurée à la ré-ouverture.
|
|
dash_duo.wait_for_no_elements(
|
|
'.marches_table td[data-dash-column="dateNotification"] p'
|
|
)
|
|
filter_input = open_page_and_check_filter_input()
|
|
_wait_input_value(dash_duo, filter_input, "11")
|
|
assert filter_input.get_attribute("value") == "11"
|
|
|
|
|
|
def test_003_tableau_download(dash_duo: DashComposite):
|
|
from src.app import app
|
|
from src.pages.acheteur import download_acheteur_data
|
|
from src.pages.tableau import download_data
|
|
from src.pages.titulaire import download_titulaire_data
|
|
|
|
# Juste pour instancier l'app
|
|
print(app.server.name)
|
|
|
|
dicts = pl.read_parquet("tests/test.parquet").to_dicts()
|
|
|
|
outputs = [
|
|
download_data(1, "", [], None),
|
|
download_acheteur_data(1, dicts, "123", "2025"),
|
|
download_titulaire_data(1, dicts, "345", "2025"),
|
|
]
|
|
for output in outputs:
|
|
assert isinstance(output, dict)
|
|
for f in ["content", "filename", "type", "base64"]:
|
|
assert f in output
|
|
assert isinstance(output["content"], str) and len(output["content"]) > 100
|
|
assert isinstance(output["filename"], str) and output["filename"].startswith(
|
|
"decp_"
|
|
)
|
|
assert output["type"] is None
|
|
assert output["base64"] is True
|
|
|
|
|
|
def test_004_add_links_observatoire_acheteur():
|
|
import polars as pl
|
|
|
|
from src.utils.table import add_links
|
|
|
|
dff = pl.DataFrame(
|
|
{
|
|
"acheteur_id": ["123"],
|
|
"acheteur_nom": ["ACHETEUR 1"],
|
|
}
|
|
)
|
|
result = add_links(dff)
|
|
nom_value = result["acheteur_nom"][0]
|
|
id_value = result["acheteur_id"][0]
|
|
|
|
# acheteur_nom should contain detail link + observatoire link
|
|
assert "/acheteurs/123" in nom_value
|
|
assert "ACHETEUR 1" in nom_value
|
|
assert "/observatoire?acheteur_id=123" in nom_value
|
|
assert "📊" in nom_value
|
|
|
|
# acheteur_id should NOT contain observatoire link
|
|
assert "/observatoire" not in id_value
|
|
|
|
|
|
def test_005_add_links_observatoire_titulaire():
|
|
import polars as pl
|
|
|
|
from src.utils.table import add_links
|
|
|
|
dff = pl.DataFrame(
|
|
{
|
|
"titulaire_id": ["345"],
|
|
"titulaire_nom": ["TITULAIRE 1"],
|
|
"titulaire_typeIdentifiant": ["SIRET"],
|
|
}
|
|
)
|
|
result = add_links(dff)
|
|
nom_value = result["titulaire_nom"][0]
|
|
id_value = result["titulaire_id"][0]
|
|
|
|
# titulaire_nom should contain detail link + observatoire link
|
|
assert "/titulaires/345" in nom_value
|
|
assert "TITULAIRE 1" in nom_value
|
|
assert "/observatoire?titulaire_id=345" in nom_value
|
|
assert "📊" in nom_value
|
|
|
|
# titulaire_id should NOT contain observatoire link
|
|
assert "/observatoire" not in id_value
|
|
|
|
|
|
def test_006_observatoire_url_to_input(dash_duo: DashComposite):
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
# Navigate to observatoire with acheteur_id query param
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/observatoire?acheteur_id=123")
|
|
dash_duo.wait_for_element("#dashboard_acheteur_id", timeout=4)
|
|
|
|
import time
|
|
|
|
time.sleep(1) # Allow callback chain to complete
|
|
|
|
acheteur_input = dash_duo.find_element("#dashboard_acheteur_id")
|
|
assert acheteur_input.get_attribute("value") == "123", (
|
|
"acheteur_id input should be populated from URL param"
|
|
)
|
|
|
|
|
|
def test_007_observatoire_share_url(dash_duo: DashComposite):
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
# Navigate to observatoire with acheteur_id query param
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/observatoire?acheteur_id=123")
|
|
dash_duo.wait_for_element("#observatoire-share-url", timeout=4)
|
|
|
|
import time
|
|
|
|
time.sleep(1) # Allow callback chain to complete
|
|
|
|
share_url_input = dash_duo.find_element("#observatoire-share-url")
|
|
share_url_value = share_url_input.get_attribute("value")
|
|
|
|
assert "acheteur_id=123" in share_url_value, (
|
|
f"Share URL should contain acheteur_id param, got: {share_url_value}"
|
|
)
|
|
|
|
|
|
def test_008_search_to_observatoire(dash_duo: DashComposite):
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
# Search for an acheteur
|
|
search_bar = dash_duo.find_element("#search")
|
|
search_bar.send_keys("ACHETEUR 1")
|
|
search_bar.send_keys(Keys.ENTER)
|
|
|
|
dash_duo.wait_for_element("#results_acheteur_datatable", timeout=2)
|
|
|
|
# Find the observatoire link in acheteur_nom column
|
|
observatoire_link = dash_duo.find_element(
|
|
'#results_acheteur_datatable td[data-dash-column="acheteur_nom"] a[href*="observatoire"]'
|
|
)
|
|
assert "📊" in observatoire_link.text
|
|
|
|
# Click the observatoire link
|
|
observatoire_link.click()
|
|
|
|
# Wait for observatoire page to load
|
|
dash_duo.wait_for_element("#dashboard_acheteur_id", timeout=4)
|
|
|
|
import time
|
|
|
|
time.sleep(1) # Allow callback chain to complete
|
|
|
|
acheteur_input = dash_duo.find_element("#dashboard_acheteur_id")
|
|
assert acheteur_input.get_attribute("value") == "123", (
|
|
"acheteur_id input should be populated after navigating from search"
|
|
)
|
|
|
|
|
|
def test_009_observatoire_filter_persistence(dash_duo: DashComposite):
|
|
import time
|
|
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
# Clear localStorage to start from a clean state
|
|
dash_duo.driver.execute_script("localStorage.clear()")
|
|
|
|
# Navigate to observatoire without URL params
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/observatoire")
|
|
dash_duo.wait_for_element("#dashboard_acheteur_id", timeout=4)
|
|
|
|
# Set the acheteur_id text input; press Enter to trigger the debounced save callback
|
|
acheteur_input = dash_duo.find_element("#dashboard_acheteur_id")
|
|
dash_duo.clear_input(acheteur_input)
|
|
acheteur_input.send_keys("123")
|
|
acheteur_input.send_keys(Keys.ENTER)
|
|
|
|
time.sleep(0.3) # allow the save callback to write to localStorage
|
|
|
|
# Navigate away
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/")
|
|
|
|
# Navigate back without URL params
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/observatoire")
|
|
dash_duo.wait_for_element("#dashboard_acheteur_id", timeout=4)
|
|
time.sleep(0.5) # allow restore callback chain to complete
|
|
|
|
acheteur_input = dash_duo.find_element("#dashboard_acheteur_id")
|
|
assert acheteur_input.get_attribute("value") == "123", (
|
|
"acheteur_id should be restored from localStorage after navigating back"
|
|
)
|
|
|
|
# Also verify URL params still override localStorage
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/observatoire?acheteur_id=123")
|
|
dash_duo.wait_for_element("#dashboard_acheteur_id", timeout=4)
|
|
time.sleep(0.5)
|
|
|
|
acheteur_input = dash_duo.find_element("#dashboard_acheteur_id")
|
|
assert acheteur_input.get_attribute("value") == "123", (
|
|
"URL param acheteur_id should override the value stored in localStorage"
|
|
)
|
|
|
|
|
|
def test_011_observatoire_multi_param_url(dash_duo: DashComposite):
|
|
import time
|
|
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
# Navigate with multiple filter params
|
|
dash_duo.wait_for_page(
|
|
f"{dash_duo.server_url}/observatoire?annee=2024&acheteur_id=12345678901234&montant_min=10000"
|
|
)
|
|
dash_duo.wait_for_element("#dashboard_acheteur_id", timeout=4)
|
|
|
|
time.sleep(1) # Allow callback chain to complete
|
|
|
|
# Verify acheteur_id input
|
|
acheteur_input = dash_duo.find_element("#dashboard_acheteur_id")
|
|
assert acheteur_input.get_attribute("value") == "12345678901234", (
|
|
"acheteur_id input should be populated from URL param"
|
|
)
|
|
|
|
# Verify montant_min input
|
|
montant_input = dash_duo.find_element("#dashboard_montant_min")
|
|
montant_value = montant_input.get_attribute("value")
|
|
assert montant_value in ("10000", "10000.0"), (
|
|
f"montant_min input should be populated from URL param, got: {montant_value}"
|
|
)
|
|
|
|
|
|
def test_012_get_distance_histogram_returns_graph():
|
|
import polars as pl
|
|
from dash import dcc
|
|
|
|
from src.figures import get_distance_histogram
|
|
|
|
lff = pl.LazyFrame({"titulaire_distance": [1, 10, 100, 500, 1000]})
|
|
result = get_distance_histogram(lff)
|
|
assert isinstance(result, dcc.Graph)
|
|
|
|
|
|
def test_013_get_distance_histogram_handles_nulls():
|
|
import polars as pl
|
|
from dash import dcc
|
|
|
|
from src.figures import get_distance_histogram
|
|
|
|
lff = pl.LazyFrame({"titulaire_distance": [None, None, 50]})
|
|
result = get_distance_histogram(lff)
|
|
assert isinstance(result, dcc.Graph)
|
|
|
|
|
|
def test_014_get_distance_histogram_all_nulls():
|
|
import polars as pl
|
|
from dash import dcc
|
|
|
|
from src.figures import get_distance_histogram
|
|
|
|
lff = pl.LazyFrame({"titulaire_distance": pl.Series([], dtype=pl.Int64)})
|
|
result = get_distance_histogram(lff)
|
|
|
|
assert isinstance(result, dcc.Graph)
|
|
|
|
|
|
def test_015_tableau_filter_date(dash_duo: DashComposite):
|
|
from src.app import app
|
|
|
|
dash_duo.start_server(app)
|
|
dash_duo.wait_for_text_to_equal(".logo > h1", "decp.info", timeout=4)
|
|
|
|
for page in ["tableau", "acheteurs/123", "titulaires/345"]:
|
|
dash_duo.wait_for_page(f"{dash_duo.server_url}/{page}")
|
|
filter_input = '.marches_table th[data-dash-column="dateNotification"] input'
|
|
filter_cell_result = '.marches_table td[data-dash-column="dateNotification"] p'
|
|
_filter_input: WebElement = _filter_input_in_view(dash_duo, filter_input)
|
|
_filter_input.send_keys("3333") # a dateNotification that doesn't exist
|
|
_filter_input.send_keys(Keys.ENTER)
|
|
# Le filtrage est asynchrone : attendre la mise à jour du tableau plutôt
|
|
# que de lire les lignes immédiatement (sinon on lit l'état pré-filtre).
|
|
dash_duo.wait_for_no_elements(filter_cell_result, timeout=4)
|