fix: erreur rename dupliqué + feedback modal visible #95

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Colin Maudry
2026-06-29 16:45:47 +02:00
parent 2d88217bbf
commit b2806d6176
2 changed files with 9 additions and 6 deletions
+4 -1
View File
@@ -98,6 +98,9 @@ def rename_view(_n, view_id, new_name):
clean = saved_views_ui.clean_view_name(new_name)
if not view_id or not clean:
return no_update
saved_views_db.rename(int(view_id), current_user.id, clean)
try:
saved_views_db.rename(int(view_id), current_user.id, clean)
except Exception:
return no_update
views = saved_views_db.list_views(current_user.id, "tableau")
return saved_views_ui.views_table(views)
+5 -5
View File
@@ -598,15 +598,14 @@ def toggle_saved_views_bar(_pathname):
@callback(
Output("save-view-modal", "is_open"),
Input("btn-save-view", "n_clicks"),
Input("btn-save-view-confirm", "n_clicks"),
State("save-view-modal", "is_open"),
prevent_initial_call=True,
)
def toggle_save_view_modal(_open, _confirm, is_open):
return not is_open
def toggle_save_view_modal(_open):
return True
@callback(
Output("save-view-modal", "is_open", allow_duplicate=True),
Output("save-view-feedback", "children"),
Output("saved-views-refresh", "data"),
Input("btn-save-view-confirm", "n_clicks"),
@@ -620,10 +619,11 @@ def save_view(_n, name, filter_query, sort_by, hidden_columns):
has_sub = current_user_has_subscription()
clean_name, error = saved_views_ui.prepare_view_to_save(has_sub, name)
if error:
return html.Span(error, style={"color": "red"}), no_update
return True, html.Span(error, style={"color": "red"}), no_update
query = build_view_query(filter_query, sort_by, hidden_columns)
saved_views_db.upsert(current_user.id, "tableau", clean_name, query)
return (
False,
html.Span(f"Vue « {clean_name} » enregistrée.", style={"color": "green"}),
clean_name,
)